Skip to content

fix(ci): bump CI Node.js to 24 to restore npm 11 trusted publishing #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeighFinegold merged 1 commit into from
May 5, 2026
Merged

fix(ci): bump CI Node.js to 24 to restore npm 11 trusted publishing #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/automated-release-calm-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -381,7 +381,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -446,7 +446,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
Copy link
Copy Markdown
Member Author

@rocketstack-matt rocketstack-matt May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - acknowledged but not making the change.

actions/setup-node@v6 with node-version: 24 resolves to the latest 24.x in the GitHub-hosted runner toolcache, which on ubuntu-latest is well above 24.10 today. There is no realistic resolution path to an earlier 24.x minor on hosted runners. Node 24.0.0 already shipped with npm 11.3 and 24.10 ships npm 11.5+, so Trusted Publishing is satisfied at the floor regardless.

Pinning only the publish jobs to 24.10.x would also create a drift between the publish toolchain and the build/test toolchain that produces the artifact we publish, which feels worse than the theoretical reproducibility win.

registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/automated-release-calm-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
cache: pnpm
cache-dependency-path: calm-suite/calm-studio/pnpm-lock.yaml
registry-url: 'https://registry.npmjs.org'
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/automated-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -239,7 +239,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -385,7 +385,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down Expand Up @@ -450,7 +450,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
Copy link
Copy Markdown
Member Author

@rocketstack-matt rocketstack-matt May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - acknowledged but not making the change.

actions/setup-node@v6 with node-version: 24 resolves to the latest 24.x in the GitHub-hosted runner toolcache, which on ubuntu-latest is well above 24.10 today. There is no realistic resolution path to an earlier 24.x minor on hosted runners. Node 24.0.0 already shipped with npm 11.3 and 24.10 ships npm 11.5+, so Trusted Publishing is satisfied at the floor regardless.

Pinning only the publish jobs to 24.10.x would also create a drift between the publish toolchain and the build/test toolchain that produces the artifact we publish, which feels worse than the theoretical reproducibility win.

registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-sync-advent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-calm-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: 22
node-version: 24
cache: npm
cache-dependency-path: package-lock.json

Expand All @@ -58,7 +58,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: 22
node-version: 24
cache: npm
cache-dependency-path: package-lock.json

Expand All @@ -81,7 +81,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
with:
node-version: 22
node-version: 24
cache: npm
cache-dependency-path: package-lock.json

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-calm-hub-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-calm-models.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-calm-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-calm-studio-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
version: 9
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
cache: pnpm
cache-dependency-path: calm-suite/calm-studio/pnpm-lock.yaml
- run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
version: 9
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
cache: pnpm
cache-dependency-path: calm-suite/calm-studio/pnpm-lock.yaml
- run: cd calm-suite/calm-studio && pnpm install --frozen-lockfile
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-calm-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
cache: pnpm
cache-dependency-path: calm-suite/calm-studio/pnpm-lock.yaml

Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
cache: pnpm
cache-dependency-path: calm-suite/calm-studio/pnpm-lock.yaml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-calm-widgets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24
cache: npm
cache-dependency-path: package-lock.json

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-vscode-extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cve-scanning-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24
- name: Build project with NPM
run: npm install --omit=dev --ignore-scripts
working-directory: ${{ matrix.module-folder }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-scanning-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['22.x']
node-version: ['24.x']
module-folder: ['cli', 'docs', 'shared']
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/s3-docs-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 22
node-version: 24

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-lockfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '22'
node-version: 24

- name: Validate platform bindings in lockfile
run: node scripts/validate-lockfile-platforms.js
2 changes: 1 addition & 1 deletion .github/workflows/validate-renovate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: '22'
node-version: 24
cache: 'npm'

- name: Install Renovate CLI
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-spectral.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# Run Spectral
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: v22
node-version: 24

- name: Install workspace
run: npm ci
Expand Down
Loading
⚡