chore(deps): override ip-address and postcss to clear Dependabot alerts#2423
Merged
LeighFinegold merged 1 commit intofinos:mainfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to clear two Dependabot alerts in the root npm lockfile by adding npm overrides for ip-address and postcss, and by pruning stale nested lockfile entries so npm re-resolves to non-vulnerable versions.
Changes:
- Added root
overridesentries forip-addressandpostcssinpackage.json. - Removed the lockfile entries for
node_modules/ip-address@10.1.0andnode_modules/next/node_modules/postcss@8.4.31to force re-resolution under the overrides. - Lockfile metadata tidy-up (removed
dev/peerflags) foraxiosandproxy-from-env.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds overrides for ip-address and postcss to address Dependabot alerts. |
| package-lock.json | Prunes specific nested/hoisted entries so npm can re-resolve vulnerable dependencies under the overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clears two Dependabot alerts on the root package-lock.json: - alert finos#303 / GHSA-v2v4-37r5-5v8g (ip-address): bump calm-server's express-rate-limit pin to ^8.5.0; the new version declares ip-address: ^10.2.0 directly, which pulls in a patched copy at the top level. Cleaner than an override and avoids the resolution issues seen when the override prevented npm from installing ip-address at all (caught by the calm-server test suite, which uses express-rate-limit at runtime). - alert finos#287 / GHSA-qx2v-qp2m-jg93 (postcss): add a postcss: ^8.5.10 override. The top-level postcss is already at 8.5.10; the alert came from node_modules/next/node_modules/postcss@8.4.31 (Next 15.5.15 pins exact 8.4.31). The stale lockfile entry was holding the vulnerable copy in place and has been removed so npm re-resolves under the override - next now uses the hoisted top-level postcss@8.5.10.
b37bc7d to
c42dc00
Compare
LeighFinegold
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clears two Dependabot alerts on the root
package-lock.json.ip-addresscalm-server'sexpress-rate-limitpin from^8.2.2→^8.5.0. The new version declaresip-address: ^10.2.0directly, so npm installs a patched copy at the top level — no override needed.postcsspostcss: ^8.5.10override. Top-levelpostcsswas already at 8.5.10; the vulnerable copy wasnode_modules/next/node_modules/postcss@8.4.31(Next 15.5.15 pins exact 8.4.31). The stale lockfile entry has been removed so npm re-resolves under the override — next now uses the hoisted top-levelpostcss@8.5.10.Note on the ip-address approach
A previous version of this PR used
ip-address: ^10.1.1as an override and surgically removed the top-level lockfile entry. That approach broke the calm-server test suite in CI:express-rate-limitimportsip-addressat runtime, and removing the lockfile entry left it unresolvable (locally it was masked by anip-addresspackage in a parent directory). Bumpingexpress-rate-limitto a version that pulls in a patchedip-addressdirectly is cleaner and avoids the override-anchor problem entirely.Out of scope
uuid(alert #301) — the only vulnerable copy isnode_modules/mermaid/node_modules/uuid@11.1.0. A globaluuid: ^11.1.1override forces v11 onto v8 consumers (@cypress/request,@azure/msal-node,sockjs); a scopedmermaid: { uuid: ... }override caused mermaid to dedupe to the v8 hoisted copy and broke resolution. The advisory (GHSA-w5hq-g745-h8pq) is a missing buffer bounds check in the v3/v5/v6 generator path when abufargument is provided — mermaid only generates v4 IDs and does not exercise that path, so real-world risk is essentially nil. Recommend dismissing this alert with atolerable_riskjustification.ip-addressbundled inside npm CLI (node_modules/npm/node_modules/ip-address@10.1.0,inBundle:true) — not reachable via overrides. Bundled npm CLI is a release-time tool, not a runtime consumer; recommend dismiss-with-justification if Dependabot flags it.calm-suite/calm-studio— separate pnpm-managed workspace, intentionally out of scope.Type of Change
Affected Components
calm-server/)Testing
npm run test:calm-serverpasses — all 11 tests;npm installresolves cleanly; postcss/ip-address verified at correct versions in the lockfile)Checklist