fix(calm-hub): CalmHub UI Colour Improvements Refactor MCP Sever Tools#2424
Merged
jpgough-ms merged 5 commits intofinos:mainfrom May 6, 2026
Merged
fix(calm-hub): CalmHub UI Colour Improvements Refactor MCP Sever Tools#2424jpgough-ms merged 5 commits intofinos:mainfrom
jpgough-ms merged 5 commits intofinos:mainfrom
Conversation
…olDetailSection Replace hardcoded accent token with primary so all active tabs in ControlDetailSection use a single DaisyUI semantic token, ensuring uniform recolouring when the theme changes. Closes finos#2420 (item 4)
…#2420 - Refactor createControlRequirement and createControlConfiguration onto McpValidationHelper.firstError for consistency with read methods - Add max-length validation on name (200), description (1024), and JSON payloads (100k bytes) in both create methods - Add unit tests covering all new validation paths in TestControlToolsShould - Add create->list->versions->get->configure integration tests for controls in MongoMcpIntegration and NitriteMcpIntegration Closes finos#2420 (items 1-3)
github-actions
Bot
added
calm-hub
jpgough-ms
requested review from
a team,
Thels,
grahampacker-ms,
markscott-ms,
rocketstack-matt and
willosborne
as code owners
Member
|
Nit on () -> McpValidationHelper.validateMaxLength(name, 200, "Name"),This |
jpgough-ms
changed the title
…Helper Replace inline literal 200 in ControlTools and ArchitectureTools with a named constant McpValidationHelper.MAX_NAME_LENGTH, consistent with the existing MAX_DESCRIPTION_LENGTH and MAX_JSON_PAYLOAD_LENGTH constants. Update the matching unit test to reference the constant instead of the literal.
rocketstack-matt
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist