fix: broken user links#1268
Merged
jescalada merged 5 commits intofinos:mainfrom Nov 5, 2025
Merged
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 70 70
Lines 3005 3005
Branches 499 499
=======================================
Hits 2505 2505
Misses 397 397
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@andypols I fixed up some remaining user links, should be good to merge after a final check on your side! |
jescalada
approved these changes
Nov 4, 2025
Contributor
jescalada
left a comment
There was a problem hiding this comment.
LGTM after my fixes are reviewed!
I replaced the a tags in the AttestationView component to use UserLinks instead, and also adjusted a link on UserList which used the old format.
I'll be adding dynamic URLs for uiRouteAuth-defined admin routes down the line.
Contributor
Author
|
@jescalada Nice one. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #1264, fixing broken user profile links and improving maintainability by centralising user navigation into a reusable component.
Problem:
User profile links across the application were pointing to
/dashboard/user/:id, while the actual route was configured as/dashboard/admin/user/:id. This mismatch caused broken navigation in the Reviewers, Contributors, and Push Details sections.Additionally, using the
/dashboard/admin/user/:idroute prevented non-admin users from accessing these links due touiRouteAuthrestrictions.Solution
/dashboard/admin/user/:idto/dashboard/user/:idto align with existing usage.Linkfor client-side navigation, eliminating full page reloads and improving user experience.RepoDetailsandPushDetailswith the newUserLinkcomponent, ensuring future route changes require updates in only one place.The
UserLinkcomponent supports both simple usage (<UserLink username={user} />) and custom children for wrapping images or displaying alternate text.