Skip to content

fix: Correct empty pagination page numbers#1270

Closed
andypols wants to merge 2 commits intofinos:mainfrom
qube-rt:correct-empty-pagination
Closed

fix: Correct empty pagination page numbers#1270
andypols wants to merge 2 commits intofinos:mainfrom
qube-rt:correct-empty-pagination

Conversation

@andypols
Copy link
Copy Markdown
Contributor

@andypols andypols commented Nov 4, 2025

Summary

This PR changes fixes some minor UI issues with the pagination values

It changes:

  • It now says Page 0 of 0 instead of Page 1 of 0
  • Adjusted the css so it is clear when a button is disabled

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 4, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 00d7629
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/690a0dcb57040a00085c4404

@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

@github-actions github-actions Bot added the fix label Nov 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (6dc22e9) to head (00d7629).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files          70       70           
  Lines        3005     3005           
  Branches      499      499           
=======================================
  Hits         2505     2505           
  Misses        397      397           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypols
Copy link
Copy Markdown
Contributor Author

andypols commented Nov 4, 2025

Apologies for the mismatched email - this is the first push from inside QRT using git-proxy 🥳 . Is there an easy way to fix it, or do I need to push a new branch

@andypols andypols closed this Nov 4, 2025
@andypols andypols deleted the correct-empty-pagination branch November 4, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant