Skip to content

chore: add CODEOWNERS with basic setup#1381

Merged
kriswest merged 6 commits intomainfrom
codeowners-setup
Feb 17, 2026
Merged

chore: add CODEOWNERS with basic setup#1381
kriswest merged 6 commits intomainfrom
codeowners-setup

Conversation

@jescalada
Copy link
Copy Markdown
Contributor

@jescalada jescalada commented Feb 4, 2026

Sets up a basic CODEOWNERS file.

@finos/git-proxy-maintainers Feel free to make these more granular! 👍🏼

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 4, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1430a12
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69936152a67b2b00085e1e9e

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.51%. Comparing base (0b7f9ab) to head (1430a12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          66       66           
  Lines        4713     4713           
  Branches      814      814           
=======================================
  Hits         3842     3842           
  Misses        856      856           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada self-assigned this Feb 4, 2026
@kriswest
Copy link
Copy Markdown
Contributor

kriswest commented Feb 4, 2026

Let's have a chat about this at the next meeting before we merge it. We're going to need to check on the project settings with finos anyway

@kriswest
Copy link
Copy Markdown
Contributor

kriswest commented Feb 9, 2026

@jescalada and @finos/git-proxy-maintainers I've tweaked this to always use the maintainers team as a fallback (you have to add the team to every line for that to work as it uses the last rule to match).

Please do add any other areas of the code you would like to be automatically added to reviews for.

Copy link
Copy Markdown
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with a code owners with just the first line. That'll solve the immediate concern of lack of reviews before merging.

Also I think we need a branch ruleset added with the "require an approval from someone other than the last person to push to a branch".

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets#require-a-pull-request-before-merging

Comment thread .github/CODEOWNERS Outdated
@kriswest
Copy link
Copy Markdown
Contributor

Also I think we need a branch ruleset added with the "require an approval from someone other than the last person to push to a branch".

This is best practice - but its also supremely annoying at times (merging suggestions from a review, or correcting a single missed period means you can't approve until someone else pushes). But I reluctantly agree that we need to set it.

Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest enabled auto-merge (squash) February 16, 2026 18:27
@kriswest kriswest merged commit 956d5e2 into main Feb 17, 2026
25 checks passed
@kriswest
Copy link
Copy Markdown
Contributor

I have pinged help@finos.org to enable both:

  • Require an approval from someone other than the last person to push to a branch
  • Require review from CODEOWNERS

Now that this is merged.

@kriswest kriswest deleted the codeowners-setup branch February 23, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants