Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 81.51% 81.51%
=======================================
Files 66 66
Lines 4713 4713
Branches 814 814
=======================================
Hits 3842 3842
Misses 856 856
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let's have a chat about this at the next meeting before we merge it. We're going to need to check on the project settings with finos anyway |
…west Signed-off-by: Kris West <kristopher.west@natwest.com>
|
@jescalada and @finos/git-proxy-maintainers I've tweaked this to always use the maintainers team as a fallback (you have to add the team to every line for that to work as it uses the last rule to match). Please do add any other areas of the code you would like to be automatically added to reviews for. |
coopernetes
left a comment
There was a problem hiding this comment.
Let's start with a code owners with just the first line. That'll solve the immediate concern of lack of reviews before merging.
Also I think we need a branch ruleset added with the "require an approval from someone other than the last person to push to a branch".
This is best practice - but its also supremely annoying at times (merging suggestions from a review, or correcting a single missed period means you can't approve until someone else pushes). But I reluctantly agree that we need to set it. |
Signed-off-by: Kris West <kristopher.west@natwest.com>
|
I have pinged help@finos.org to enable both:
Now that this is merged. |
Sets up a basic
CODEOWNERSfile.@finos/git-proxy-maintainers Feel free to make these more granular! 👍🏼