docs: add deployment guide#1385
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 68 68
Lines 4869 4869
Branches 888 888
=======================================
Hits 4366 4366
Misses 485 485
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
761c2e7 to
dfac352
Compare
dfac352 to
24eb8e2
Compare
jescalada
left a comment
There was a problem hiding this comment.
Looks good so far! Just wondering if we could look into the config loading issue - although it might be because I tested on v1.19.2 rather than the latest rc...
As for the Docker part, I'll do some more setup testing later so we can refine this 👍🏼
Co-authored-by: Juan Escalada <97265671+jescalada@users.noreply.github.com> Signed-off-by: Tabatha DiDomenico <tabatha@gr-oss.io>
Signed-off-by: Tabatha DiDomenico <tabatha.didomenico@gresearch.co.uk>
|
Love to see this going in for v2 and would also like to know why the preview build is failing. I think we could include some content on loadbalancing. I think the app should loadbalance fine (when using Mongodb) - even if you usually only have one node, knowing that you can deploy a second would enable zero-downtime deployments. I'll raise an issue to check if anyone is actively doing this with their deployment. Edit: I note the comment about MongoDB being required for multi-instance deployments. We could go a little further as Git proxy does use local storage during processing but its ephemeral at the moment and relates to only a single request (doesn't need to persist). That will not change with @fabiovincenzi's caching contribution - it just means the nodes will have different caches (and you may want to latch users to particular nodes where possible to make best use of caches). |
kriswest
left a comment
There was a problem hiding this comment.
LGTM - although the node version info is about to become out-of-date - @jescalada @1462 will need rebasing after this merges and will need to update the node version range in deployment.mdx.
This should merge now so that it goes out with 2.0.0
There is a check failing, but I think its not the PRs fault, but a timeout and just needs to be re-run.
Part of #1325, complements #1335.
Adds a deployment guide covering:
Also adds the deployment page to the docs sidebar.