feat(config): require merged top-level defaults#1514
Open
dcoric wants to merge 2 commits intofinos:mainfrom
Open
feat(config): require merged top-level defaults#1514dcoric wants to merge 2 commits intofinos:mainfrom
dcoric wants to merge 2 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 90.21% 90.78% +0.56%
==========================================
Files 69 69
Lines 5511 5543 +32
Branches 944 939 -5
==========================================
+ Hits 4972 5032 +60
+ Misses 521 494 -27
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1287.
This updates config loading so user override files can keep using the generated optional
GitProxyConfigtype, while the merged runtime configuration is narrowed to a stricterFullGitProxyConfigafter defaults are applied and verified.Changes
FullGitProxyConfigtype for the merged runtime configuration.Validation
npm run check-types:servernpm test -- test/testConfig.test.tsnpm run lint