Prompt for ABIU runtime settings when creating a backend from the "deploy" flow as well#10406
Conversation
…ploy" flow as well
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes runtime resolution logic into a new resolveRuntime helper function, ensuring consistent behavior across backend setup and deployment. It also adds comprehensive unit tests for this logic. The review feedback suggests enhancing doSetupSourceDeploy to accept and propagate a rootDir parameter instead of using a hardcoded value, which is necessary for supporting monorepos or projects where the application resides in a subdirectory.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The user can create a backend in 3 ways:
This PR adds support for #3.
Scenarios Tested
firebase deploywith a backend that doesn't exist yet. I verified that i was asked the ABIU runtime questions and my backend was created correctly with the correct runtime and ABIU settings.