Add support for asynchrous iterators for arguments#47
Open
Ikatono wants to merge 3 commits intoflorimondmanca:masterfrom
Open
Add support for asynchrous iterators for arguments#47Ikatono wants to merge 3 commits intoflorimondmanca:masterfrom
Ikatono wants to merge 3 commits intoflorimondmanca:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 334 346 +12
=========================================
+ Hits 334 346 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to start processing arguments before you've generated all of them. This was a feature trimeter had (I referenced their implementation when writing this).
This passes the existing test suite (all sync iterators) and a couple rough tests I ran using an async iterator, but could probably use a few additional automated tests.
#46