Skip to content

Fix list of category posts#369

Merged
florimondmanca merged 1 commit intomasterfrom
fm/fix-category-list
Sep 29, 2022
Merged

Fix list of category posts#369
florimondmanca merged 1 commit intomasterfrom
fm/fix-category-list

Conversation

@florimondmanca
Copy link
Copy Markdown
Owner

@florimondmanca florimondmanca commented Sep 29, 2022

Post-merge fix for #359

Category pages such as https://florimond.dev/en/category/tutorials/ were not showing any pages anymore.

Aka the problems of no type checking in Jinja2 templates.

Also of not having any E2E tests.

@florimondmanca florimondmanca added the bug Something isn't working label Sep 29, 2022
@florimondmanca florimondmanca mentioned this pull request Sep 29, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #369 (e2fcd8a) into master (62e28eb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines          800       800           
=========================================
  Hits           800       800           
Impacted Files Coverage Δ
server/domain/repositories.py 100.00% <ø> (ø)
server/infrastructure/repositories.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@florimondmanca florimondmanca merged commit 15615ad into master Sep 29, 2022
@florimondmanca florimondmanca deleted the fm/fix-category-list branch September 29, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants