fix: validate --source flag in create kustomization command#5798
Merged
matheuscscp merged 1 commit intofluxcd:mainfrom Mar 30, 2026
Merged
Conversation
Signed-off-by: Ghassan Malke <gmalke@shiftbase.com>
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
flux create kustomizationwithout--sourcesilently accepts the command and forwards a broken Kustomization to the API server with emptysourceReffields. The API server then returns:A user seeing this has no indication that
--sourceis the missing flag. The error refers to an internal API field they never set directly.Fix
Validate
--sourcebefore generating or applying the resource:source is requiredFollows the same pattern used in
create helmrelease.Testing
Added
TestCreateKustomizationcovering the missing--sourcescenario.