Suppress health check events when no changes made#151
Merged
stefanprodan merged 2 commits intofluxcd:mainfrom Oct 22, 2020
Merged
Suppress health check events when no changes made#151stefanprodan merged 2 commits intofluxcd:mainfrom
stefanprodan merged 2 commits intofluxcd:mainfrom
Conversation
Member
|
@ordovicia I think it's ok to suppress the events no matter the dependencies. If a dependency is failing, it will never get to the health check part. |
Because if a dependency is failing, the reconciliation will never get to the health check part.
Contributor
Author
|
Ah, right. Thank you. |
stefanprodan
approved these changes
Oct 21, 2020
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @ordovicia 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no Kubernetes resources are created or configured for a
Kustomizationand it has no dependencies, the health check status for theKustomizationwill not change.In this case kustomize-controller does not have to deliver health check events.
What do you think?