Skip to content

Add feature gate to cancel health checks on new revisions#1520

Merged
matheuscscp merged 1 commit intomainfrom
cancel-health-checks
Sep 25, 2025
Merged

Add feature gate to cancel health checks on new revisions#1520
matheuscscp merged 1 commit intomainfrom
cancel-health-checks

Conversation

@matheuscscp
Copy link
Copy Markdown
Member

@matheuscscp matheuscscp commented Sep 25, 2025

This PR introduces the feature gate CancelHealthCheckOnNewRevision for allowing health checks to be cancelled earlier in case a new revision of the source is observed.

Co-authored-by: @trashhalo (xref: #1518)
Includes: fluxcd/pkg#1033

@stefanprodan stefanprodan added area/kstatus Health checking related issues and pull requests area/ux In pursuit of a delightful user experience labels Sep 25, 2025
Comment thread internal/controller/kustomization_controller.go Outdated
Comment thread internal/controller/kustomization_controller.go Outdated
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Co-authored-by: Stephen Solka <stephen@standd.io>
Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp and @trashhalo

@matheuscscp matheuscscp merged commit d7d96f5 into main Sep 25, 2025
5 checks passed
@matheuscscp matheuscscp deleted the cancel-health-checks branch September 25, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kstatus Health checking related issues and pull requests area/ux In pursuit of a delightful user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants