Fix enqueing the same revision while reconciling#1614
Merged
matheuscscp merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
added
bug
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: fluxcd/helm-controller#1429
We traced the behavior reported in the issue back to the enqueue functions: they skip enqueue when the object is Ready=True and the revision matches. This should also happen if Reconciling=True. This check works because the object is patched with the attempted revision on the beginning of the reconciliation. Note that there's still a (very) small window where the object is not patched yet in which the issue can still happen.