Update kustomize/api to v0.7.2 and disable kyaml#241
Merged
stefanprodan merged 2 commits intomainfrom Jan 19, 2021
Merged
Conversation
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
reviewed
Jan 17, 2021
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
Can you provide information on what this change incorporates and how it fixes the issue referenced to in the PR? Either in-code or in the commit message.
stefanprodan
changed the title
stefanprodan
added
area/kustomize
stefanprodan
force-pushed
the
kustomize/api-v0.7.2
branch
2 times, most recently
from
ccf4f02 to
5a37e19
Compare
Workaround for upstream bug: kubernetes-sigs/kustomize#3446 Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
kustomize/api-v0.7.2
branch
from
5a37e19 to
085588b
Compare
hiddeco
approved these changes
Jan 18, 2021
Comment on lines
+282
to
+289
| // buildKustomization wraps krusty.MakeKustomizer with the following settings: | ||
| // - disable kyaml due to critical bugs like: | ||
| // - https://github.com/kubernetes-sigs/kustomize/issues/3446 | ||
| // - https://github.com/kubernetes-sigs/kustomize/issues/3480 | ||
| // - reorder the resources just before output (Namespaces and Cluster roles/role bindings first, CRDs before CRs, Webhooks last) | ||
| // - load files from outside the kustomization.yaml root | ||
| // - disable plugins except for the builtin ones | ||
| // - prohibit changes to resourceIds, patch name/kind don't overwrite target name/kind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
kustomize/apito v0.7.2 and disableskyamlwhen running kustomize build due to upstream bugs:Note that when
kyamlis enabled,Kustomizer.Runfails withError: json: unsupported type: map[interface {}]interface {}without any hint to which object caused the error, making it impossible for Flux users to track down the incompatible manifest.Also if a manifest contains duplicate keys, kyaml panics thus crashing the whole controller 😢
Fix: fluxcd/flux2#729
Fix: #243