Implement var substitution from ConfigMaps and Secrets#275
Merged
stefanprodan merged 2 commits intomainfrom Feb 16, 2021
Merged
Implement var substitution from ConfigMaps and Secrets#275stefanprodan merged 2 commits intomainfrom
stefanprodan merged 2 commits intomainfrom
Conversation
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
1f8cb01 to
ccb71a6
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
ccb71a6 to
401fec6
Compare
hiddeco
reviewed
Feb 16, 2021
hiddeco
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an array field called
substituteFromto the post build API.SubstituteFromholds references toConfigMapsandSecretscontaining the variables (data keys) and their values (data values) to be substituted in the YAML manifests.You can disable the variable substitution for certain resources by either labeling or annotating them with:
Example:
Fix: #274
Followup: #253