Validate the var names before substitution#291
Merged
stefanprodan merged 1 commit intomainfrom Mar 2, 2021
Merged
Conversation
stefanprodan
added
enhancement
stefanprodan
changed the title
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
var-validation
branch
from
e3955d9 to
cb72a77
Compare
hiddeco
approved these changes
Mar 1, 2021
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
LGTM, thank you @stefanprodan 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of a variable used in post build substitutions can contain only alphanumeric and underscore characters. This PR implements validation for the variable names using
^[_[:alpha:]][_[:alpha:][:digit:]]*$regex.Fix: #290