fix: prevent nil pointer dereference in health checks

[makkes]

The lastStatus map now stores event.ResourceStatus values instead
of pointers to them, preventing nil pointers being dereferenced by
accident.

refs #374

Signed-off-by: Max Jonas Werner mail@makk.es

[makkes]

@stefanprodan as promised.

[hiddeco]

Wouldn't this result in L92-100 tripping because it now deals with an initialized but empty object, and wouldn't it thus be better to keep the pointer list, but deal with nil values there?

Only non-nil values are added to the list, so this will not happen, but I still think the dereference makes little sense.

(In general I think, pointer object lists often use pointers because nil has a special meaning, and you want to maintain this information for as long as you may need it).

[hiddeco]

This addresses all my (personal) previous concerns, thank you @makkes 💯

[hiddeco]

DCO signoff (and while you are at it, a smash of) commits is still required.

[stefanprodan]

LGTM

Thanks @makkes