Skip to content

Ensure event annotations are prefixed with Group FQDN #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanprodan merged 2 commits into from
Mar 24, 2022
Merged

Ensure event annotations are prefixed with Group FQDN #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db5777f
Ensure annotations are prefixed with Group FQDN
hiddeco Mar 23, 2022
0787d8b
Fix Kustomize version in go.mod comment
stefanprodan Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/kustomization_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ func (r *KustomizationReconciler) Reconcile(ctx context.Context, req ctrl.Reques
kustomization.Spec.Interval.Duration.String())
log.Info(msg, "revision", source.GetArtifact().Revision)
r.event(ctx, reconciledKustomization, source.GetArtifact().Revision, events.EventSeverityInfo,
msg, map[string]string{"commit_status": "update"})
msg, map[string]string{kustomizev1.GroupVersion.Group + "/commit_status": "update"})
return ctrl.Result{RequeueAfter: kustomization.Spec.Interval.Duration}, nil
}

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect
)

// pin kustomize to v4.4.1
// pin kustomize to v4.5.2
replace (
sigs.k8s.io/kustomize/api => sigs.k8s.io/kustomize/api v0.10.1
sigs.k8s.io/kustomize/kyaml => sigs.k8s.io/kustomize/kyaml v0.13.0
Expand Down
⚡