sops/awskms: Fix AWS KMS config creation#667
Merged
hiddeco merged 1 commit intofluxcd:mainfrom May 27, 2022
Merged
Conversation
hiddeco
reviewed
May 27, 2022
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
Out of interest: any chance you can link me to the doc ref around profiles?
aryan9600
force-pushed
the
aws-kms-decryption
branch
from
6be4f5b to
f3a7084
Compare
aryan9600
changed the title
aryan9600
force-pushed
the
aws-kms-decryption
branch
from
f3a7084 to
01edc3b
Compare
hiddeco
reviewed
May 27, 2022
aryan9600
force-pushed
the
aws-kms-decryption
branch
from
01edc3b to
928be40
Compare
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
aryan9600
changed the title
aryan9600
force-pushed
the
aws-kms-decryption
branch
from
928be40 to
10bc7ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #641 which fixes a few things around AWS KMS config creation and expands related tests.
Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works