Support alternative kustomization file names#738
Merged
Conversation
makkes
added
bug
hiddeco
reviewed
Oct 4, 2022
hiddeco
reviewed
Oct 4, 2022
hiddeco
reviewed
Oct 4, 2022
Member
hiddeco
left a comment
hiddeco
left a comment
There was a problem hiding this comment.
Changes look good to me, but think smashing (especially the last commit) would be better to keep main free from noise.
`KustomizeGenerator.WriteFile` now detects alternative kustomization file names such as `kustomization.yml` and `Kustomization`. closes #737 Signed-off-by: Max Jonas Werner <max@e13.dev>
Member
Author
Sure thing, was planning to do that, anyway. Just wanted to simplify review. Will squash now. |
makkes
force-pushed
the
alternative-kustomization-files
branch
from
8c0a7e0 to
c3c4cc1
Compare
hiddeco
changed the title
hiddeco
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KustomizeGenerator.WriteFilenow detects alternative kustomizationfile names such as
kustomization.ymlandKustomization.closes #737