Refactor: Adopt Flux runtime conditions and status standards#745
Merged
stefanprodan merged 6 commits intomainfrom Oct 18, 2022
Merged
Refactor: Adopt Flux runtime conditions and status standards#745stefanprodan merged 6 commits intomainfrom
stefanprodan merged 6 commits intomainfrom
Conversation
deaf9ca to
de4fcdd
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
b247c0d to
761835c
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
761835c to
1357acb
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
c28550b to
4261236
Compare
ProgressingWithRetry signals that the controller is going to retry the last failed reconciliation at a later time. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
cca7b02 to
5552840
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
5552840 to
747a2c9
Compare
makkes
approved these changes
Oct 18, 2022
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
7 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Kustomization.statusconform to the Kubernetes kstatus standardKustomization.status.conditionsconform to the Kubernetes standard conditionsfluxcd/pkg/runtime/conditionsandfluxcd/pkg/runtime/controllerfor status operationsTest image:
ghcr.io/fluxcd/kustomize-controller:rc-747a2c9eReconcilingstatus conditionThis PR introduces a new status condition named
Reconcilingwhich improves the observability for the actions performed by the controller during a reconciliation run.The
Reconcilingmessage reflects the current action being executed e.g.:Xwith a timeout ofYXwith a timeout ofYXwith a timeout ofYXwith a timeout ofYThe
Reconcilingcondition is added to the status once the reconciliation starts and itsMessageis updated before each action performed by the controller during a reconciliation run.If the reconciliation encountered an error, the
Readycondition is set toFalseandReconcilingis left in place, to signal that the controller will retry the failed action.If the reconciliation finishes with no errors, The
Reconcilingcondition is removed from status and theReadycondition is set toTrue.Closes: #663
Ref: fluxcd/pkg#380