Skip to content

Refactor: Generate manifests with flux/pkg/kustomize#763

Merged
stefanprodan merged 2 commits intofluxcd:mainfrom
souleb:use-pkg-kustomize
Nov 16, 2022
Merged

Refactor: Generate manifests with flux/pkg/kustomize#763
stefanprodan merged 2 commits intofluxcd:mainfrom
souleb:use-pkg-kustomize

Conversation

@souleb
Copy link
Copy Markdown
Member

@souleb souleb commented Nov 14, 2022

Signed-off-by: Soule BA bah.soule@gmail.com

This has to be merged after fluxcd/pkg#392.

If this is implemented, it will use the same code base as flux build/diff kustomization for kustomize generation and variable substitution and will ease maintenance.

@souleb souleb marked this pull request as draft November 14, 2022 14:55
@souleb
Copy link
Copy Markdown
Member Author

souleb commented Nov 14, 2022

The test should pass after #765 is merged.

@pjbgf
Copy link
Copy Markdown
Member

pjbgf commented Nov 14, 2022

@souleb please rebase and try again.

Signed-off-by: Soule BA <bah.soule@gmail.com>
@souleb souleb marked this pull request as ready for review November 15, 2022 11:12
@stefanprodan stefanprodan changed the title Replace internal/generator by flux/pkg/kustomize Refactor: Generate manifests with flux/pkg/kustomize Nov 16, 2022
@stefanprodan stefanprodan added the area/kustomize Kustomize related issues and pull requests label Nov 16, 2022
Signed-off-by: Soule BA <bah.soule@gmail.com>
Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🏅

@stefanprodan stefanprodan merged commit 814a79f into fluxcd:main Nov 16, 2022
@souleb souleb deleted the use-pkg-kustomize branch November 16, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kustomize Kustomize related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants