Use kustomization namespace for empty dependency source namespace#897
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Jun 23, 2023
Merged
Conversation
Kustomize controller uses the namespace of the kustomization resource if the sourceRef is empty. However, this policy doesn't applied to dependencies. This can be problematic if the same named `Sources` without explicit namespace is in different namespace. This commit fixes this issue by using kustomization's namespace when checking dependencies if the namespace in sourceRef is empty. Signed-off-by: Sunghoon Kang <me@hoon.dev>
stefanprodan
approved these changes
Jun 23, 2023
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Great find, thanks @devholic for the fix 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kustomize controller uses the namespace of the kustomization resource if the sourceRef is empty. However, this policy doesn't applied to dependencies. This can be problematic if the same named
Sourceswithout explicit namespace is in different namespace.This commit fixes this issue by using kustomization's namespace when checking dependencies if the namespace in sourceRef is empty.