Add Support for SAS keys in Azure Blob#738
Merged
pjbgf merged 2 commits intofluxcd:mainfrom Aug 12, 2022
Merged
Conversation
pjbgf
reviewed
May 26, 2022
pjbgf
reviewed
May 26, 2022
pjbgf
reviewed
May 26, 2022
stefanprodan
added
area/bucket
30 tasks
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
8b4c399 to
a92403f
Compare
pjbgf
reviewed
Jun 10, 2022
pjbgf
reviewed
Jun 10, 2022
pjbgf
requested changes
Jun 10, 2022
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
A few nits. And I think we need some safeguards to ensure SAS tokens would leak into errors.
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
94a5342 to
7182c56
Compare
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
7182c56 to
0670db7
Compare
pjbgf
reviewed
Jun 29, 2022
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
b2f0826 to
c3eabe2
Compare
pjbgf
reviewed
Jun 29, 2022
pjbgf
approved these changes
Jun 30, 2022
Member
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
LGTM
thanks for getting this implemented @somtochiama! 🙇♂️
Member
|
@somtochiama do you mind rebasing please? |
hiddeco
reviewed
Jul 8, 2022
Comment on lines
+535
to
+536
| The query values from the `sasKey` data field in the Secrets gets merged with the `spec.endpoint` of the `Bucket`. | ||
| If the same key is present in the both of them, the token takes precedence. |
Member
There was a problem hiding this comment.
I feel this could use more explanation. In combination with looking at the doc page of the added ref, I had at least the following questions:
-
Does the
sasKeyonly contain the "SAS token"? -
If so, is it expected to be prefixed with
?as suggested in the documentation? -
What does
If the same key is present in the both of them, the token takes precedence.
entail precisely?
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
dfc4ac6 to
044b8c3
Compare
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
044b8c3 to
3526863
Compare
Member
|
@somtochiama thank you for addressing @hiddeco 's point. Can you rebase please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for SAS Keys in Azure Blob.
The SAS token is specified in the secret under
sasKeyfield.Fixes: #719
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com