fix(msg): add new msg_show.shell_out to default routes for messages

[dpetka2001]

Description

Add new shell_out for Neovim 0.11 onwards as kind for external commands messages

Related Issue(s)

Fixes #1097

Screenshots

[lljbash]

It seems that just adding shell_out is not enough.

[dpetka2001]

I added shell_err and shell_ret, that seem related to the aforementioned issue. Not sure about the rest. Folke can decide what he further wants to include or not.

[lljbash]

I guess this fixes #1096 as well.

[dpetka2001]

No, it doesn't from my testing. Something else must be amiss there, not sure what.

[lljbash]

BTW, do you think it is a mistake that :Noice filters out almost everything from msg_show by default?

noice.nvim/lua/noice/config/init.lua

Lines 60 to 106 in 0427460

	-- You can add any custom commands below that will be available with `:Noice command`
	---@type table<string, NoiceCommand>
	commands = {
	history = {
	-- options for the message history that you get with `:Noice`
	view = "split",
	opts = { enter = true, format = "details" },
	filter = {
	any = {
	{ event = "notify" },
	{ error = true },
	{ warning = true },
	{ event = "msg_show", kind = { "" } },
	{ event = "lsp", kind = "message" },
	},
	},
	},
	-- :Noice last
	last = {
	view = "popup",
	opts = { enter = true, format = "details" },
	filter = {
	any = {
	{ event = "notify" },
	{ error = true },
	{ warning = true },
	{ event = "msg_show", kind = { "" } },
	{ event = "lsp", kind = "message" },
	},
	},
	filter_opts = { count = 1 },
	},
	-- :Noice errors
	errors = {
	-- options for the message history that you get with `:Noice`
	view = "popup",
	opts = { enter = true, format = "details" },
	filter = { error = true },
	filter_opts = { reverse = true },
	},
	all = {
	-- options for the message history that you get with `:Noice`
	view = "split",
	opts = { enter = true, format = "details" },
	filter = {},
	},
	},

At least with :Noice telescope I would like to see everything and filter it manually. Maybe using the all filter config for telescope?

noice.nvim/lua/telescope/_extensions/noice.lua

Lines 36 to 40 in 0427460

	local messages = Manager.get(Config.options.commands.history.filter, {
	history = true,
	sort = true,
	reverse = true,
	})

[dpetka2001]

Sorry, but you're asking the wrong person about this. I have limited programming experience and am not familiar with Noice codebase at all.

This PR was just a simple fix. You should direct your question towards Folke.

[dpetka2001]

I found something interesting regarding #1096. If you add print(#self._messages > 0) here before line 157

noice.nvim/lua/noice/view/init.lua

Lines 156 to 159 in 0427460

	function View:display()
	if #self._messages > 0 then
	Format.align(self._messages, self._opts.align)
	self:check_options()

, then this will be printed in the popup view.

It seems like the token from command lua require("noice").redirect("echo 3") is somehow being consumed?? No idea what might be causing this. Just mentioning this in case you might be able to figure out something that I fail to think of.

[github-actions]

This PR is stale because it has been open 30 days with no activity.

[Avsilver]

Helped with a lot of headache. Hopefully this gets merged.

[github-actions]

This PR is stale because it has been open 30 days with no activity.