fix(showMessage): use on_message handler

[tris203]

Replace typo _on_message with on_message in the LSP message handler.

Description

Related Issue(s)

Closes #1074

Screenshots

[github-actions]

This PR is stale because it has been open 30 days with no activity.

[tris203]

Not stale

[github-actions]

This PR is stale because it has been open 30 days with no activity.

[tris203]

Still pending

[fennecdjay]

this is actually pretty helpful!
I'm making a LSP for my own language, showMessage can be super useful for debugging it and i couldn't find why it didn't work

[github-actions]

This PR is stale because it has been open 30 days with no activity.

[tris203]

No

[matthee]

I've also run into this bug. This PR seems to fix this error.

[matthee]

I was looking though git blame. You might want to use Util.protect(M.on_message) to restore the previous behavior.

See 0f5f8c93

Suggested change

	vim.lsp.handlers["window/showMessage"] = M.on_message
	vim.lsp.handlers["window/showMessage"] = Util.protect(M.on_message)

[liancheng]

Looks reasonable, but I'm not sure, since @folke explicitly removed the Util.protect call in the same commit changing M.on_message to M._on_message. Might be a typo, though.

[liancheng]

Adding the Util.protect call gives me the following error upon LazyVim startup:

   Error  09:35:36 AM notify.error noice.nvim `vim.lsp.handlers["window/showMessage"]` has been overwritten by another plugin?

Either disable the other plugin or set `config.lsp.message.enabled = false` in your **Noice** config.
  - plugin: noice.nvim
  - file: /home/lian/.local/share/nvim/lazy/noice.nvim/lua/noice/util/call.lua
  - line: 51

[liancheng]

Hit the same issue and same fix while debugging my own language server using LazyVim.

[liancheng]

A non-intrusive workaround: #1074 (comment)