fix(hover): incorrect doc positions

[cameronr]

Description

The code to layout the lsp hover window was not handling a number of edge cases (anchoring E without a border, anchoring S and/or E with a border, and when hover window is too large to fit). These are all fixed and all combinations of position, padding, and border are handled correctly (afaik).

To fix all of these cases, we calculate position correctly, accounting for border and padding, and then set the maximum size accordingly.

Here are a bunch of screenshots to show the fixed layout:

No border:

1. below the cursor (anchoring NE)

2. above the cursor (anchoring SE) 3. anchoring NW 4. anchoring SW

Border:

1. NE

2. SE 3. NW 4.SW

Overlapping other windows:

Resizing (so window doesn't get pushed onto cursor line, last line is statusline):

Resizing with small window:

Unusual position, padding with border and large max_height:

      lsp = {
        hover = {
          opts = {
            size = {
              max_height = 30,
            },
            position = { row = 5, col = 4 },
            border = {
              style = 'rounded',
              padding = { 2, 4 },
            },
          },
        },
      },

1. NE

2. SE 3. NW 4. SW

Related Issue(s)

Fixes #1122

Screenshots

[whymidnight]

<3 for relieving my headaches. until this gets merged - packer:

  use({
  "cameronr/noice.nvim",
  branch = "lsp-doc-position",
  requires = {
    "MunifTanjim/nui.nvim",
    "rcarriga/nvim-notify",
    }
  })

[github-actions]

This PR is stale because it has been open 30 days with no activity.

[DrKJeff16]

PR Labeler bot will ask you to rename this PR to something like:

fix: incorrect doc positions