Vertical metrics must be consistent in superfamilies

[davelab6]

The vertical metrics of these 2 families should be identical,

https://fonts.google.com/specimen/Archivo
https://fonts.google.com/specimen/Archivo+Narrow

But they aren't. This suggests to me that there is a class of font bakery checks missing for 'super families' to keep them consistent. We now have quite a few super families, typically with different widths, but also different optical sizes (eg "Something Sans" and "Something Sans Display" or "Something Sans Micro")

Should be

[Omnibus-Type]

Hi! About Archivo and Archivo Narrow vMetrics, please note that they must also match with Archivo Black vMetrics…

[m4rc1e]

@Omnibus-Type thanks for adding that info.

I'm in two minds about this. I agree that every super family should have consistent vertical metrics. However, this is not really possible if the fonts have already been released and have differing metrics. By trying to unify the metrics, we'll introduce a regression and may cause doc reflow problems.

I agree that all new super families which are not yet released must have consistent vertical metrics.

My policy so far has been 'if the font has been released, the vertical metrics should visually match its previous release.'. We use this rules for styles and glyphs as well :-)

[davelab6]

However, asap and archivo's super family parts were just released this week, so there's not yet a lot of usage to break, and fontbakery can have a whitelist in cases where we don't want it to warn on discrepencies across families -- if we take your approach.

I am more of the mind that inconsistent line heights across styles within a family (or within a superfamily, indeed) is a nasty bug that is worth fixing.

[Omnibus-Type]

@m4rc1e If I had to establish a starting point in the matches, our priority would be to have Archivo vMetrics match those of Archivo Narrow. What do you think about this?

BTW: Regarding the next Asap update (now with 8 fonts), the same criteria apply: vMatrics should be matched between the standard version (Asap) and the condensed version (Asap Condensed):

[m4rc1e]

@Omnibus-Type Asap and Asap condensed already have the same vert metrics. It is just Archivo

@davelab6 we'll roll with your proposal and see if any issues are filed.

[Omnibus-Type]

@m4rc1e Please note that Asap latest version has now 8 styles (Regular, Medium, Semi Bold, Bold plus Italics). Thus, Asap Condensed will completely match Asap. Can you update it, please? Thanks in advance.

[m4rc1e]

@Omnibus-Type 8 styles were added in pr google/fonts#1119

Since there are only 6 fonts on GF currently, thats all i could do with the gif.