Proposal: Configurable check for OS/2 achVendID.#3941
Closed
bramstein wants to merge 2 commits intofonttools:mainfrom
Closed
Proposal: Configurable check for OS/2 achVendID.#3941bramstein wants to merge 2 commits intofonttools:mainfrom
bramstein wants to merge 2 commits intofonttools:mainfrom
Conversation
felipesanches
added
New check proposal
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Nov 7, 2022
com.thetypefounders/check/vendor_id When a font project's Vendor ID is specified explicitely on FontBakery's configuration file, all binaries must have a matching vendor identifier value in the OS/2 table. (PR fonttools#3941)
Collaborator
|
I've added an entry to CHANGELOG.md and made a few code-style adjustments to your contribution. The resulting code was squashed into a single commit and will be merged at the follow-up PR: #3942 Thanks, @bramstein |
felipesanches
pushed a commit
to felipesanches/fontbakery
that referenced
this pull request
Nov 7, 2022
com.thetypefounders/check/vendor_id When a font project's Vendor ID is specified explicitely on FontBakery's configuration file, all binaries must have a matching vendor identifier value in the OS/2 table. (PR fonttools#3941)
felipesanches
pushed a commit
that referenced
this pull request
Nov 7, 2022
com.thetypefounders/check/vendor_id When a font project's Vendor ID is specified explicitely on FontBakery's configuration file, all binaries must have a matching vendor identifier value in the OS/2 table. (PR #3941)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We manage fonts for multiple foundries and would like to use a check for the OS/2 achVendID (vendor ID) value. We often see cases where some families have the correct vendor ID, while other families (or even styles) within the same foundry have a different vendor id. Rather than creating a profile and checks for each of our foundries, it seems sensible to make the vendor id check configurable. That way, each foundry can have a
.fontbakery.yamlfile (or similar) that configures its own vendor ID. The check is skipped if the configuration value is not found.This is different from
com.google.fonts/check/vendor_id(which checks if the vendor id is not set to a default value and registered) andcom.fontwerk/check/vendor_id(which checks for a single foundry). I've added it to the opentype/universal profile since it seems generally useful to other foundries, but please let me know if you prefer to keep it in a (new)thetypefoundersprofile.To Do
CHANGELOG.md