Skip to content

Fix test_checks_unique_glyphnames #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipesanches merged 3 commits into from
Jun 2, 2025
+5 −2
Merged

Fix test_checks_unique_glyphnames #5024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de977cb
Fix test_checks_unique_glyphnames
ollimeier Jun 1, 2025
fa755c1
Update CHANGELOG.md
ollimeier Jun 1, 2025
3a44bd0
Update CHANGELOG.md
felipesanches Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
Below are the noteworthy changes from each release.
A more detailed list of changes is available in the corresponding milestones for each release in the Github issue tracker (https://github.com/googlefonts/fontbakery/milestones?state=closed).

## Upcoming release: 1.0.0 (2025-Jun-??)
### Bugfixes
- fonttools==4.58.0 has been changed (PR #https://github.com/fonttools/fonttools/pull/3809/): It fixes duplicate names, therefore the test for the `unique_glyphnames`check was failing. (issue #5023)

## 1.0.0 (2025-May-07)
## 1.0.0 (2025-May-07)
- See also: https://github.com/fonttools/fontspector

### Migration of checks
Expand Down
2 changes: 1 addition & 1 deletion tests/test_checks_unique_glyphnames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ def test_check_unique_glyphnames(check):

# Load again, we changed the font directly.
ttFont = TTFont(TEST_FILE("nunito/Nunito-Regular.ttf"))
ttFont.setGlyphOrder(glyph_names)
# Just access the data to make fonttools generate it.
ttFont["post"] # pylint:disable=pointless-statement
_file = io.BytesIO()
_file.name = ttFont.reader.file.name
ttFont.save(_file)
ttFont = TTFont(_file)
ttFont.setGlyphOrder(glyph_names)
message = assert_results_contain(check(ttFont), FAIL, "duplicated-glyph-names")
assert "space" in message

Expand Down
⚡