Use as_file context correctly in pkg_resources replacement (Alternate solution)#5045
Merged
felipesanches merged 1 commit intomainfrom Sep 29, 2025
Merged
Use as_file context correctly in pkg_resources replacement (Alternate solution)#5045felipesanches merged 1 commit intomainfrom
felipesanches merged 1 commit intomainfrom
Conversation
Collaborator
|
Something is bad on the Windows builds. |
Contributor
Author
|
Yeah, I have no idea what's happening. Not sure if it's related to this PR or something else is going on… |
Contributor
|
Per https://github.com/fonttools/fontbakery/graphs/contributors @madig you are the biggest dama contributor, and afaik DaMa is the biggest Windows user of fontbakery (and tbh probably in the type world outside of Redmond ;) PTAL? :) |
Contributor
|
I'm not sure this is related to Windows. The logs contain a crash somewhere: https://github.com/fonttools/fontbakery/actions/runs/17401850138/job/49396693818?pr=5045#step:4:398. Maybe this causes pytest to not be installed actually, so it won't be found later. Edit: A rerun fixed the issue. Cosmic radiation or something. |
felipesanches
force-pushed
the
remove-pkg_resources-fixup-2
branch
from
04046e0 to
78e25ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to issue #5039