[family_and_style_max_length] Modernize check#5049
Merged
felipesanches merged 1 commit intofonttools:mainfrom Oct 2, 2025
Merged
Conversation
Collaborator
Author
|
The git history of PR #5020 was getting too convoluted so I git squashed everything into a single commit, rebased it with git main and fixed some linting warnings and updated the CHANGELOG file. This is much cleaner for us to resume work reviewing the check update. |
9 tasks
felipesanches
force-pushed
the
modernize_check__family_and_style_max_length
branch
2 times, most recently
from
8803166 to
9202385
Compare
Relates to issue fonttools#2179, specifically later comments and testing, like fonttools#2179 (comment) Changes: - Change main static font check to consider NameID 1 (FONT_FAMILY_NAME) rather than NameID 4 (FULL_FONT_NAME). - Change VF check to test NameID 16 + STAT particles. - Update tests to pass with new check criteria.
felipesanches
force-pushed
the
modernize_check__family_and_style_max_length
branch
from
9202385 to
a50e11e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a followup to PR #5020
Original message written by @arrowtype:
Relates to issue #2179, specifically later comments and testing, like #2179 (comment)
Changes:
Note: I later noticed that this PR actually removes the checking of NameID 6.