[opentype/monospace] Ensure check works with monospace OTF fonts#5051
Merged
felipesanches merged 2 commits intofonttools:mainfrom Oct 14, 2025
klim-type-foundry:fix/opentype-monospace-glyf
Merged
[opentype/monospace] Ensure check works with monospace OTF fonts#5051felipesanches merged 2 commits intofonttools:mainfrom klim-type-foundry:fix/opentype-monospace-glyf
felipesanches merged 2 commits intofonttools:mainfrom
klim-type-foundry:fix/opentype-monospace-glyf
Conversation
Collaborator
|
Can you please update You can add an entry under a new section: Upcoming release v1.1.1 (2025-Oct-?)Changes to existing checksOn the OpenType profile
Here the raw markdown code: ## Upcoming release v1.1.1 (2025-Oct-?)
### Changes to existing checks
#### On the OpenType profile
- **[check-id]**: something something (PR #5051) |
Contributor
Author
|
Thank you @felipesanches, I've updated Also, I've just signed the Google CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5040
The
opentype/monospacereturned anERRORstatus for monospace OTF fonts. This is because it tries to access theglyftable, which does not exist. The only reason theglyftable is accessed is to get the glyph names. To enable this to work for OTF and TTF alike, I instead used theTTFont.getGlyphNames()method.I tried to add a monospace OTF font to the unit tests, but unfortunately I couldn't find an open source monospace OTF that would pass all of the checks. Maybe someone can recommend a suitable OTF file to use?
Checklist
CHANGELOG.md