Remove hard-coded FastClick dependency; Fixes #3643#3668
Remove hard-coded FastClick dependency; Fixes #3643#3668fny wants to merge 1 commit intofoundation:masterfrom fny:patch-1
Conversation
FastClick should be an opt-in feature or loaded in a more discrete fashion. The dependency prevents Foundation from loading in the document `<head />` and breaks compatability with other libraries such as Rails Turbolinks. See also RailsApps/rails_layout#5. This really should be removed sooner than later...
|
Thanks for the pull request! I'm going to close this in favor of the pull request attached to #3643 which relocates when FastClick is hooked up instead of removing it altogether. |
|
@seantimm While this is a better temporary fix, FastClick should still be moved out of Foundation's primary closure. There's no point: FastClick will escape and become a global variable. How should we go about implementing this properly? |
|
What version will this change be in? Once that happens it can be added to the jsbin "Add library" list. |
|
v5.0.3
|
|
And when will there be a CDN'd version of that? |
|
I have remove the fastclick code frome foundation.js but it still dont work if i put in my head: I should put it in the body to make it work. Thanks. |
|
jsbin.com adds libraries to the HEAD. So foundation 5 can't be added to the |
4 participants
FastClick should be an opt-in feature or loaded in a more discrete fashion. The dependency prevents Foundation from loading in the document
<head />and breaks compatability with other libraries such as Rails Turbolinks. See also RailsApps/rails_layout#5.This really should be removed sooner than later...