Skip to content

feat: Payments based dunning#35689

Merged
deepeshgarg007 merged 66 commits intofrappe:developfrom
marination:payments-based-dunning
Jul 20, 2023
Merged

feat: Payments based dunning#35689
deepeshgarg007 merged 66 commits intofrappe:developfrom
marination:payments-based-dunning

Conversation

@marination
Copy link
Copy Markdown
Collaborator

@marination marination commented Jun 14, 2023

An attempt to revive #27528


Related to #26969

Create dunning for all overdue payments of a customer. We use a table similar to the payment schedule in sales invoice to pull all overdue scheduled payments into the Dunning.

  • Rate of Interest is the same for all overdue payments.
  • Interest amount is calculated for each overdue payment.
  • Dunning Fee is applied only once per dunning.

Changes in accounting

  • Dunning amount will no longer be booked to receivables. The reason is that the dunning amount is not paid in many cases / is only intended as a warning. If paid, the dunning amount will be recorded as additional income in Payment Entry. See here and here for further reading (in german).

Preview:

new_dunning

Docs: https://docs.erpnext.com/docs/v13/user/manual/en/accounts/dunning?editWiki=1&wikiPagePatch=318ad1abe6
Discuss: https://discuss.erpnext.com/t/dunning-mahnung-warning-notice/49499/30?u=rmeyer


ToDo:

barredterra
barredterra previously approved these changes Jul 3, 2023
Copy link
Copy Markdown
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@barredterra barredterra added the backport version-14-hotfix backport to version 14 label Jul 3, 2023
@barredterra barredterra removed their assignment Jul 4, 2023
@marination
Copy link
Copy Markdown
Collaborator Author

@deepeshgarg007 This is tested, reviewed and ready to merge. You can give it a last check and let us know if it looks okay.

@marination
Copy link
Copy Markdown
Collaborator Author

@deepeshgarg007 the patch reverses GL entries for unresolved dunnings. Will it be problematic if there are some old unresolved dunnings ? From before the Accounts Frozen Till Date ? Those should stay untouched right ?

@marination
Copy link
Copy Markdown
Collaborator Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 20, 2023

backport version-14-hotfix

❌ No backport have been created

Details
  • Backport to branch version-14-hotfix failed

Git reported the following error:

error: commit e686bb07396428c8c6072a96cd1a789bf902123b is a merge but no -m option was given.
fatal: cherry-pick failed

@muchai
Copy link
Copy Markdown

muchai commented Oct 26, 2023

This could use a backport to version 14 please.

@bosue
Copy link
Copy Markdown
Contributor

bosue commented Oct 26, 2023

@muchai: This is a massive change, so backporting would break lots of custom code in v14 IMO. Also, it‘s still experimental, so not fully settled in v15. We all loved the feature and wanted to see it in v15, but IMO there‘s still much to do until it may be considered stable and be backported. So instead, you might want to upgrade to v15?

But that‘s just my two cents. I personally don‘t care if it‘s backported. I just can‘t consider it finished, and while having quite many advantages, there‘s a couple of drawbacks, including lost features that should probably be reinstated before backporting.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 19, 2024
@barredterra barredterra removed the backport version-14-hotfix backport to version 14 label Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants