Skip to content

fix!: make reorder_level not required#35831

Merged
deepeshgarg007 merged 2 commits intofrappe:developfrom
pps190:fix-non-reqd-reorder
Jun 24, 2023
Merged

fix!: make reorder_level not required#35831
deepeshgarg007 merged 2 commits intofrappe:developfrom
pps190:fix-non-reqd-reorder

Conversation

@dj12djdjs
Copy link
Copy Markdown
Collaborator

Use Case: You want to auto create a material transfer for 2pc when stock level reaches zero.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2023

Codecov Report

Merging #35831 (a601f70) into develop (39a1f4a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35831   +/-   ##
========================================
  Coverage    64.27%   64.27%           
========================================
  Files          811      811           
  Lines        62051    62051           
========================================
  Hits         39886    39886           
  Misses       22165    22165           
Impacted Files Coverage Δ
erpnext/stock/reorder_item.py 73.33% <100.00%> (ø)

@deepeshgarg007 deepeshgarg007 merged commit f9ed8c1 into frappe:develop Jun 24, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 23, 2024
@barredterra barredterra changed the title fix: make reorder_level not required fix!: make reorder_level not required Nov 13, 2025
@barredterra
Copy link
Copy Markdown
Collaborator

barredterra commented Nov 13, 2025

Breaking changes like these (< -> <=) should be documented in the migration guide! Suddenly all users get unexpected Material Requests after upgrading to v15.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants