fix: stop creating transaction logs

[barredterra]

Creation of Transaction Logs was enabled for Germany only, but it's not really needed here. At least I haven't come across that requirement again in the six years since enabling this feature.

Refer also: #49342

The use for France has already been moved to scopen-coop/erpnext_france.

Migration Guide: https://github.com/frappe/erpnext/wiki/Migration-Guide-To-ERPNext-Version-16

[coderabbitai]

📝 Walkthrough

Walkthrough

• Removed the regional transaction log hook from erpnext/hooks.py:
  • Sales Invoice on_submit no longer calls erpnext.regional.create_transaction_log; it now only calls erpnext.regional.italy.utils.sales_invoice_on_submit.
  • Payment Entry on_submit hook entry was removed entirely.
• Deleted create_transaction_log(doc, method) from erpnext/regional/init.py; check_deletion_permission remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: add option to disable Transaction Log #49342 — Modifies the same create_transaction_log in erpnext/regional/init.py by adding a disable flag guard; directly intersects with its removal here.

Suggested labels

regional

Suggested reviewers

• ruthra-kumar

---

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ece6eb and aefcf56.

📒 Files selected for processing (2)

• erpnext/hooks.py (0 hunks)
• erpnext/regional/__init__.py (0 hunks)

💤 Files with no reviewable changes (2)

• erpnext/regional/init.py
• erpnext/hooks.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Patch Test
• GitHub Check: Python Unit Tests (4)
• GitHub Check: Python Unit Tests (1)
• GitHub Check: Python Unit Tests (2)
• GitHub Check: Python Unit Tests (3)
• GitHub Check: Summary

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.