Skip to content

fix: UOM of item not fetching in BOM#52043

Merged
rohitwaghchaure merged 1 commit intofrappe:developfrom
rohitwaghchaure:fixed-uom-not-fetching-in-bom
Jan 25, 2026
Merged

fix: UOM of item not fetching in BOM#52043
rohitwaghchaure merged 1 commit intofrappe:developfrom
rohitwaghchaure:fixed-uom-not-fetching-in-bom

Conversation

@rohitwaghchaure
Copy link
Copy Markdown
Collaborator

Screen.Recording.2026-01-24.at.2.16.17.PM.mov

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

This change removes an unnecessary re-binding of the local variable d inside the callback function of get_bom_material_detail in the BOM JavaScript file. The callback now directly extends the existing d object with r.message rather than reassigning it. The observable behavior, error handling, and control flow remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only a video link without explanatory text, making it impossible to assess whether the description meaningfully relates to the changeset. Add a text-based description explaining the UOM fetching issue, the root cause, and how the code change fixes it. Include steps to reproduce if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: UOM of item not fetching in BOM' accurately describes the primary change - fixing a UOM fetching issue in BOM, which aligns with the code changes removing unnecessary variable rebinding that was likely causing the issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohitwaghchaure rohitwaghchaure merged commit c5a4164 into frappe:develop Jan 25, 2026
12 of 13 checks passed
rohitwaghchaure added a commit that referenced this pull request Jan 25, 2026
…-52043

fix: UOM of item not fetching in BOM (backport #52043)
rohitwaghchaure added a commit that referenced this pull request Jan 25, 2026
…-52043

fix: UOM of item not fetching in BOM (backport #52043)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant