feat: add button-full-width class to Button component#1
Closed
kamaljohnson wants to merge 5 commits intofrappe:mainfrom
Closed
feat: add button-full-width class to Button component#1kamaljohnson wants to merge 5 commits intofrappe:mainfrom
kamaljohnson wants to merge 5 commits intofrappe:mainfrom
Conversation
NagariaHussain
requested changes
Feb 4, 2022
| <Button icon-left="menu">Menu</Button> | ||
| <Button icon-right="external-link">Link</Button> | ||
| <Button :loading="true">Loading</Button> | ||
| <Button :button-full-width="true">Full Width Button</Button> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <Button :button-full-width="true">Full Width Button</Button> | |
| <Button :full-width="true">Full Width Button</Button> |
Button is redundant anyways, the readability remains same.
Contributor
Author
There was a problem hiding this comment.
Yeah I was going to do the same, but the naming which was used in the Dropdown component for this class is this
frappe-ui/src/components/Dropdown.vue
Lines 85 to 88 in b1dc1ff
I named the class in the same way to maintain consistency throughout.
I too think we should just use full-width instead.
Contributor
Author
There was a problem hiding this comment.
I have refactored the class tag from button-full-width -> width-full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Added class
button-full-widthwhich when set to true will set the button width to the element width that it is contained in, Itis set to false as default.How to use
In action
When used within other components