Skip to content

Fix: Incorrect month display in Month view due to day-of-month comparison #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srihamat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Incorrect month display in Month view due to day-of-month comparison #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/date_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,26 @@ export default {
minutes = seconds / 60;
hours = minutes / 60;
days = hours / 24;

// Calculate months across years
let yearDiff = date_a.getFullYear() - date_b.getFullYear();
let monthDiff = date_a.getMonth() - date_b.getMonth();
// calculate extra
monthDiff += (days % 30) / 30;

/* If monthDiff is negative, date_b is in an earlier month than
date_a and thus subtracted from the year difference in months */

// Simple month calculation without day-of-month adjustment
// This prevents incorrect month shifts in Month view
months = yearDiff * 12 + monthDiff;
/* If date_a's (e.g. march 1st) day of the month is smaller than date_b (e.g. february 28th),
adjust the month difference */
if (date_a.getDate() < date_b.getDate()) {
months--;

// For non-month scales, add fractional month based on day difference
if (scale !== 'month' && scale !== 'months') {
// calculate extra
monthDiff += (days % 30) / 30;
months = yearDiff * 12 + monthDiff;

/* If date_a's (e.g. march 1st) day of the month is smaller than date_b (e.g. february 28th),
adjust the month difference */
if (date_a.getDate() < date_b.getDate()) {
months--;
}
}

// Calculate years based on actual months
Expand Down
⚡