fix get navItem object bug by Navigation.get(target) method.#1410
Open
NameHitherto wants to merge 1 commit intofuturepress:masterfrom
Open
fix get navItem object bug by Navigation.get(target) method.#1410NameHitherto wants to merge 1 commit intofuturepress:masterfrom
NameHitherto wants to merge 1 commit intofuturepress:masterfrom
Conversation
(cherry picked from commit 79de4c1)
hiive
pushed a commit
to hiive/epub.js
that referenced
this pull request
Apr 6, 2026
…urepress#1285, futurepress#1265, futurepress#1339, futurepress#1407 - futurepress#1410: Fix Navigation.get() ID lookup — strip # before tocById lookup - futurepress#1393: Fix encoded URI substitution — try decodeURIComponent before regex - futurepress#1285: Parse fallback attribute in manifest items (EPUB spec compliance) - futurepress#1265: Treat page numbers as strings — fixes non-numeric page labels (Roman numerals) - futurepress#1339: Fix TypeScript types — currentLocation() returns Location not DisplayedLocation - futurepress#1407: Ensure at least one location per section — fixes picture-only EPUBs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I want to use the
get(target: string)method innavigation.jsto get the target navItem I encountered a bug, the method provides two means of querying based on theidorhrefattributes of thenavItem, when I need to query based on theidI need to manually add the # character, while at this time the target is no longer equal to the id value of the target navItem. So I restore the target value after the determination is over:epub.js/src/navigation.js
Line 90 in f09089c
and before calling getByIndex:
epub.js/src/navigation.js
Line 96 in f09089c