fix: make session the first argument of update_datafusion_session (delta-io#4192)

# Description

`update_datafusion_session` currently updates the state of the Session
while receiving it as the second argument.

This change reorders the function parameters so that the Session is
passed as the first argument, matching the intent discussed in the
issue.

# Related Issue(s)

 - closes delta-io#4139

# Documentation

---------

Signed-off-by: Paul Douane <paul.douane@icloud.com>
Co-authored-by: Paul Douane <paul.douane@icloud.com>

Author: pauldouane

crates/core/src/delta_datafusion/table_provider.rs

@@ -754,8 +754,8 @@ impl DeltaTable {
 }
 
 pub(crate) fn update_datafusion_session(
-    log_store: &dyn LogStore,
     session: &dyn Session,
+    log_store: &dyn LogStore,
     operation_id: Option<Uuid>,
 ) -> DeltaResult<()> {
     crate::delta_datafusion::DeltaSessionExt::ensure_object_store_registered(

crates/core/src/delta_datafusion/table_provider/next/mod.rs

@@ -453,7 +453,7 @@ impl TableProvider for DeltaScan {
             )
         })?;
 
-        super::update_datafusion_session(log_store.as_ref(), state, None)?;
+        super::update_datafusion_session(state, log_store.as_ref(), None)?;
 
         let snapshot = match &self.snapshot {
             SnapshotWrapper::EagerSnapshot(esnap) => esnap.as_ref().clone(),

crates/core/src/operations/delete.rs

@@ -226,7 +226,7 @@ impl std::future::IntoFuture for DeleteBuilder {
                     cdc: false,
                 },
             )?;
-            update_datafusion_session(&this.log_store, &session, Some(operation_id))?;
+            update_datafusion_session(&session, &this.log_store, Some(operation_id))?;
             session.ensure_log_store_registered(this.log_store.as_ref())?;
 
             let predicate = this

crates/core/src/operations/update.rs

@@ -460,7 +460,7 @@ impl std::future::IntoFuture for UpdateBuilder {
                     cdc: false,
                 },
             )?;
-            update_datafusion_session(&this.log_store, &state, Some(operation_id))?;
+            update_datafusion_session(&state, &this.log_store, Some(operation_id))?;
             state.ensure_log_store_registered(this.log_store.as_ref())?;
 
             if this.updates.is_empty() {

crates/core/src/operations/write/mod.rs

@@ -477,7 +477,7 @@ impl std::future::IntoFuture for WriteBuilder {
                     },
                 )?;
 
-                update_datafusion_session(&this.log_store, &session, Some(operation_id))?;
+                update_datafusion_session(&session, &this.log_store, Some(operation_id))?;
                 session.ensure_log_store_registered(this.log_store.as_ref())?;
 
                 let mut schema_drift = false;