WIP: Bump versions of babel-eslint, eslint and eslint-config-canonical

[pnevyk]

I bumped versions of babel-eslint, eslint and eslint-config-canonical. Because babel-eslint have changed their scope analysis in this commit to visit also some type annotations, some tests were failing (related issue: #336), in particular, define-flow-type and use-flow-type.

Tests in use-flow-type rule were failing because the no-unused lint error wasn't being thrown anymore. Tests in define-flow-type were failing because the no-undef lint error wasn't being thrown anymore. I removed the tests.

So these changes were required to get our tests working with new parser and eslint. However, I think that with a pull request to babel-eslint we will be able to get rid of define-flow-type and use-flow-type rules entirely. I filed the issue few months ago without a response so I will try to create a pull request with needed changes. If they get approved, then we can remove mentioned rules and publish new major version of the plugin. I will update this pull request accordingly.

Btw, there is already v10.0.0 version of babel-eslint but I couldn't use it because this commit started to rename TypeAlias nodes into FunctionDeclaration and it of course broke a lot of our rules.

Because of eslint-config-canonical update, I had to apply lint fixes to a lot of files. It kind of messes this pull request, however, I wasn't able to separate lint and bump changes into two commits. the most important files of this pull request are source and test files for define-flow-type and use-flow-type.

[gajus]

🎉 This PR is included in version 2.50.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[pnevyk]

@gajus This PR was not supposed to be merged yet, hence I prefixed it with WIP. I intended it to be a major change removing the mentioned rules and adding support for newer babel-eslint and eslint. Nevertheless, I will continue on getting rid of define-flow-type and use-flow-type as mentioned in #336 in a separate PR.

[gajus]

@gajus This PR was not supposed to be merged yet, hence I prefixed it with WIP. I intended it to be a major change removing the mentioned rules and adding support for newer babel-eslint and eslint. Nevertheless, I will continue on getting rid of define-flow-type and use-flow-type as mentioned in #336 in a separate PR.

Bummer. My bad. Ping when the follow up PR is ready.