feat: Add require-compound-type-alias#365
Merged
gajus merged 1 commit intogajus:masterfrom Oct 26, 2018
Merged
Conversation
Owner
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a rule which enforces to use type aliases for union and intersection types. I found myself that when I use them in their "raw" or "explicit" (or how to call it?) form I ended up with copy&pasting them all over the code where they were needed. This was true especially when I didn't know they will be needed somewhere else first and this requirement came afterwards. I know that not using copy&paste of code is kind of developer's responsibility and elementary "skill" but laziness sometimes wins.
The name of the rule can be discussed. We have already
union-intersection-spacingrule so using compound type phrase is a little inconsistency. Also I don't know if it is clear what is meant by compound type for the first look.