Test tools in parallel, with regular user permissions, without a shared filesystem#118
Merged
rhpvorderman merged 6 commits intogalaxyproject:masterfrom Apr 8, 2019
Merged
Conversation
mvdbeek
changed the title
rhpvorderman
requested changes
Apr 4, 2019
Contributor
rhpvorderman
left a comment
rhpvorderman
left a comment
There was a problem hiding this comment.
Could you write a test for this feature in the pytest code? I don't think testing tools in galaxy is tested yet in ephemeris. (The parallelization of tests is hard to test)
Also handle cases of `log` not being set (this needs to be refactored, that is not how logging works).
mvdbeek
force-pushed
the
quick_testing
branch
3 times, most recently
from
4d16ea1 to
dd5119e
Compare
Member
Author
|
Alright, test are done and passing at https://travis-ci.org/galaxyproject/ephemeris/jobs/515746753 |
rhpvorderman
approved these changes
Apr 8, 2019
Contributor
|
Looks great! |
Contributor
|
Thanks a lot @mvdbeek for implementing this! |
Member
Author
|
Thanks for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need a galaxy-lib update with galaxyproject/galaxy#7167 for re-using the history.We've got a new galaxy-lib update, so let's get this in. It allows testing tools without an admin API key and without a shared filesystem.