Fix crash when too_with_panel is empty#120
Merged
rhpvorderman merged 2 commits intogalaxyproject:masterfrom Jan 9, 2019
jvanbraekel:fix-crash
Merged
Fix crash when too_with_panel is empty#120rhpvorderman merged 2 commits intogalaxyproject:masterfrom jvanbraekel:fix-crash
rhpvorderman merged 2 commits intogalaxyproject:masterfrom
jvanbraekel:fix-crash
Conversation
When tool_with_panel is empty and ToolSheedClient.get_repositories() is not it was crashing because tool_panel_section_id/label were not defined. Fix : Define them outside of the loop to match the use later inside the if condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tool_with_panel was empty and ToolSheedClient.get_repositories() was not it was crashing because tool_panel_section_id/label were not defined. Fix : Define them outside of the loop to match the use later inside the if condition.
Make a new branch/pull request because inside the other one there was a mysterious anoying sticky white space inserted.