Handle timeout gracefully for UWSGI connection#123
Merged
rhpvorderman merged 3 commits intomasterfrom Mar 18, 2019
Merged
Conversation
mvdbeek
force-pushed
the
uwsgi_connection_aborted
branch
from
d8a1111 to
f7a04b9
Compare
rhpvorderman
requested changes
Mar 18, 2019
Contributor
rhpvorderman
left a comment
rhpvorderman
left a comment
There was a problem hiding this comment.
Looks good to me. Just one extra documenting comment (IMHO) and this can be merged.
| if tool.get("model_class") == 'DataManagerTool': | ||
| repositories.append(get_repo_from_tool(tool)) | ||
| repo = get_repo_from_tool(tool) | ||
| if repo: |
Contributor
There was a problem hiding this comment.
This is a good idea if a tool does not have a repo. Could you add a comment here with an example of why this is needed? For the people who read the code in the future and do not know all galaxy specifics by heart.
Member
|
The download from NCBI doesn't seem to work currently, that may be an intermittent issue since it worked on Friday. |
rhpvorderman
approved these changes
Mar 18, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really know what I'm doing here, but following @mvdbeek suggestion :-).