Skip to content

Data library creation would hang forever if you had a single non-ok command ever #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 7 commits into from
Jul 16, 2019
Merged

Data library creation would hang forever if you had a single non-ok command ever #138

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffffaa0
Do not wait forever
hexylena Jun 19, 2019
db3d8ad
support legacy
hexylena Jun 19, 2019
6b039a2
fetch non-terminal
hexylena Jun 19, 2019
6f5bd26
Fix condition + log any failures instead of dying
hexylena Jun 19, 2019
a16cd76
non bare except
hexylena Jun 19, 2019
8cba4b4
Swap to exception
hexylena Jun 19, 2019
e5cd4b0
Update src/ephemeris/setup_data_libraries.py
hexylena Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ephemeris/setup_data_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def populate_items(base_folder_id, has_items):
folder_id=base_folder_id,
file_type=has_items['ext']
)
except:
except Exception:
Comment thread
hexylena marked this conversation as resolved.
log.error("Could not upload %s to %s/%s", has_items['url'], lib_id, base_folder_id)
return None

Expand Down
⚡